diff options
| author | Tom Rini | 2017-05-10 15:20:14 -0400 |
|---|---|---|
| committer | Tom Rini | 2017-05-12 08:37:38 -0400 |
| commit | 62f733b396cbe39315e9f28ea348300c6a72caa9 (patch) | |
| tree | 1279626f8d5ae8807b72b9afb366efcf4a983b18 /cmd/led.c | |
| parent | 9398b8ce5ff619be2b913a44f0b4705d444b1a19 (diff) | |
cmd/led.c: Remove unnecessary check on 'cmd' value
We first check that if argc is less than 2 we return CMD_RET_USAGE. We
then see if argc is greater than 2 and if so call get_led_cmd() to set
'cmd' and otherwise set it to LEDST_COUNT (which will always be positive
as it's an enum with 0 already assigned). Therefore the test on if cmd
is less than 0 will always be false and simply be omitted. Reported by
clang-3.8.
Signed-off-by: Tom Rini <trini@konsulko.com>
Diffstat (limited to 'cmd/led.c')
| -rw-r--r-- | cmd/led.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/cmd/led.c b/cmd/led.c index 84173f86f22..bdfb16c0e09 100644 --- a/cmd/led.c +++ b/cmd/led.c @@ -90,8 +90,6 @@ int do_led(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]) return list_leds(); cmd = argc > 2 ? get_led_cmd(argv[2]) : LEDST_COUNT; - if (cmd < 0) - return CMD_RET_USAGE; #ifdef CONFIG_LED_BLINK if (cmd == LEDST_BLINK) { if (argc < 4) |