aboutsummaryrefslogtreecommitdiff
path: root/cmd
diff options
context:
space:
mode:
authorMarek BehĂșn2021-10-05 15:56:06 +0200
committerJagan Teki2021-10-23 15:47:33 +0530
commit0d1ecc99cb59c2190257f7738f91db21f174dc02 (patch)
treebd610819dcce9dd95ff9c8e43411c53986abbf31 /cmd
parenta60397d219c2ddbceedfea4e121e303804d333d0 (diff)
mtd: Remove mtd_erase_callback() entirely
The original purpose of mtd_erase_callback() in Linux at the time it was imported to U-Boot, was to inform the caller that erasing is done (since it was an asynchronous operation). All supplied callback methods in U-Boot do nothing, but the mtd_erase_callback() function was (until previous patch) grossly abused in U-Boot's mtdpart implementation for completely different purpose. Since we got rid of the abusement, remove the mtd_erase_callback() function and the .callback member from struct erase_info entirely, in order to avoid such problems in the future. Signed-off-by: Marek BehĂșn <marek.behun@nic.cz>
Diffstat (limited to 'cmd')
-rw-r--r--cmd/onenand.c9
1 files changed, 2 insertions, 7 deletions
diff --git a/cmd/onenand.c b/cmd/onenand.c
index 852ed5c7b21..592985a7ee3 100644
--- a/cmd/onenand.c
+++ b/cmd/onenand.c
@@ -186,9 +186,7 @@ next:
static int onenand_block_erase(u32 start, u32 size, int force)
{
struct onenand_chip *this = mtd->priv;
- struct erase_info instr = {
- .callback = NULL,
- };
+ struct erase_info instr = {};
loff_t ofs;
int ret;
int blocksize = 1 << this->erase_shift;
@@ -219,10 +217,7 @@ static int onenand_block_erase(u32 start, u32 size, int force)
static int onenand_block_test(u32 start, u32 size)
{
struct onenand_chip *this = mtd->priv;
- struct erase_info instr = {
- .callback = NULL,
- .priv = 0,
- };
+ struct erase_info instr = {};
int blocks;
loff_t ofs;