diff options
| author | Tom Rini | 2017-06-13 07:10:35 -0400 |
|---|---|---|
| committer | Simon Glass | 2017-07-11 10:08:20 -0600 |
| commit | 99bb38e2cce9d99238458e0f6d1880c6d2e80a4d (patch) | |
| tree | f155f75b8323132fa07b992cd3fc8ac89a87520b /cmd | |
| parent | f53dcc0e35b46f169432448d8db254b0d6776806 (diff) | |
fdt: Check for NULL return from fdt_getprop in 'fdt set'
While the previous pass through fixed one place where we knew that
fdt_getprop would be given a positive len, in the case of 'fdt set' we
do not, so check that we did no get NULL from fdt_getprop().
Cc: Simon Glass <sjg@chromium.org>
Reported-by: Coverity (CID: 163249)
Fixes 72c98ed1ab48 ("fdt: Add a check to do_fdt() for coverity")
Signed-off-by: Tom Rini <trini@konsulko.com>
Reviewed-by: Simon Glass <sjg@chromium.org>
Diffstat (limited to 'cmd')
| -rw-r--r-- | cmd/fdt.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/cmd/fdt.c b/cmd/fdt.c index 31a536198c8..05e19f8a72b 100644 --- a/cmd/fdt.c +++ b/cmd/fdt.c @@ -284,6 +284,10 @@ static int do_fdt(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]) len = 0; } else { ptmp = fdt_getprop(working_fdt, nodeoffset, prop, &len); + if (!ptmp) { + printf("prop (%s) not found!\n", prop); + return 1; + } if (len > SCRATCHPAD) { printf("prop (%d) doesn't fit in scratchpad!\n", len); |