diff options
| author | Quentin Schulz | 2024-06-10 18:11:44 +0200 |
|---|---|---|
| committer | Tom Rini | 2024-06-13 09:31:56 -0600 |
| commit | ca6a992e09441d6cca73439c63c3735f86b36ea4 (patch) | |
| tree | 0c6094a996e937d45325f9cde4281919e11ad28e /cmd | |
| parent | 53de4841bda27c0068ae4c1684e0cabc271d7951 (diff) | |
cmd: sound: fix help text
There's never been a -q or -s argument handled in the command, so let's
remove it. This was highlighted during review[1] but somehow still got
through.
While at it, slightly "reword" in the help text how the len + freq
arguments are defined. Indeed, len and freq work in pair, it is possible
to define none of either, n of both, or n - 1 of freq if there are n
len, in which case the freq that goes with the last len would be the n -
1 (and not the default of 400Hz if neither len nor freq is passed). I
assume this isn't what's expected but leaving it for another patch if
need be to fix what happens in that very odd scenario.
[1] https://lore.kernel.org/u-boot/CAPnjgZ0QWNqVFZfEWHxRcFOA3E3gRAZCYs77nGUXKL0pLp+JLQ@mail.gmail.com/
Fixes: ea58b9a404d4 ("cmd: allow sound command to play multiple sounds")
Signed-off-by: Quentin Schulz <quentin.schulz@cherry.de>
Reviewed-by: Simon Glass <sjg@chromium.org>
Diffstat (limited to 'cmd')
| -rw-r--r-- | cmd/sound.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/cmd/sound.c b/cmd/sound.c index 0b7f9599716..bc44a431609 100644 --- a/cmd/sound.c +++ b/cmd/sound.c @@ -99,7 +99,7 @@ U_BOOT_CMD( sound, INT_MAX, 1, do_sound, "sound sub-system", "init - initialise the sound driver\n" - "sound play [[[-q|-s] len [freq]] ...] - play sounds\n" + "sound play [len [freq [len [freq ...]]]] - play sounds\n" " len - duration in ms\n" " freq - frequency in Hz\n" ); |