diff options
| author | Eugeniu Rosca | 2019-04-01 12:45:33 +0200 |
|---|---|---|
| committer | Simon Glass | 2019-04-23 20:26:43 -0600 |
| commit | d9313efc2e61e8f827ed30c5a911a20c1f43df7c (patch) | |
| tree | 688676cd0ad418cf17e98b717c8e2ec31c954be4 /common/image-fdt.c | |
| parent | 6c5f8dd540d7a8eff244d4c27a09451ca12c8d20 (diff) | |
fdt: boot_get_fdt: remove redundant zeroing out
Paranoid programming [1] lies at the foundation of proper software
development, but the repetitive zeroing-out of output arguments in the
context of the same function rather clutters the code and inhibits
further refactoring/optimization than is doing any good.
In boot_get_fdt(), we already perform zero/NULL-initialization of
*of_flat_tree and *of_size at the beginning of the function, so doing
the same at function error-out is redundant/superfluous.
Moreover, keeping the code unchanged might encourage the developers to
update *of_flat_tree and *of_size during some interim computations,
which is against the current design of boot_get_fdt(). Currently,
writing useful data into these arguments happens just before
successfully returning from boot_get_fdt() and it should better stay so.
[1] https://blog.regehr.org/archives/1106
Signed-off-by: Eugeniu Rosca <erosca@de.adit-jv.com>
Reviewed-by: Simon Glass <sjg@chromium.org>
Diffstat (limited to 'common/image-fdt.c')
| -rw-r--r-- | common/image-fdt.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/common/image-fdt.c b/common/image-fdt.c index 01186aeac7a..1817ce6bce3 100644 --- a/common/image-fdt.c +++ b/common/image-fdt.c @@ -489,8 +489,6 @@ int boot_get_fdt(int flag, int argc, char * const argv[], uint8_t arch, no_fdt: ok_no_fdt = 1; error: - *of_flat_tree = NULL; - *of_size = 0; if (!select && ok_no_fdt) { debug("Continuing to boot without FDT\n"); return 0; |