aboutsummaryrefslogtreecommitdiff
path: root/common/spl/spl_ext.c
diff options
context:
space:
mode:
authorThomas Schaefer2020-06-16 22:03:52 +0200
committerTom Rini2020-07-17 08:51:01 -0400
commitea5003ad66b2c42d57496cbdf75218d0e15e41a5 (patch)
tree6619e1b515d91c74d2c6aa88610384f013daeaad /common/spl/spl_ext.c
parent9b83f9c594af6033dd507c3ecad1231421063949 (diff)
spl: fix ext4fs_mount return code handling
- Despite other ext4 filesystem functions, ext4fs_mount returns 0 in case of error. - This leads to u-boot crash in case that an SD card with valid partition table but without ext4 filesystem created in a partition is found on SD card. - Fix this by returning a proper error code of '-1' from spl_load_image_ext function in case of ext4fs_mount error. Signed-off-by: Thomas Schaefer <thomas.schaefer@kontron.com> [hthiery: slightly reword the commit message] Signed-off-by: Heiko Thiery <heiko.thiery@gmail.com> Reviewed-by: Tom Rini <trini@konsulko.com>
Diffstat (limited to 'common/spl/spl_ext.c')
-rw-r--r--common/spl/spl_ext.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/common/spl/spl_ext.c b/common/spl/spl_ext.c
index 3898041d106..d73f0627621 100644
--- a/common/spl/spl_ext.c
+++ b/common/spl/spl_ext.c
@@ -32,7 +32,7 @@ int spl_load_image_ext(struct spl_image_info *spl_image,
#ifdef CONFIG_SPL_LIBCOMMON_SUPPORT
printf("%s: ext4fs mount err - %d\n", __func__, err);
#endif
- goto end;
+ return -1;
}
err = ext4fs_open(filename, &filelen);