aboutsummaryrefslogtreecommitdiff
path: root/doc/device-tree-bindings/gpio
diff options
context:
space:
mode:
authorRasmus Villemoes2020-01-28 12:04:34 +0000
committerTom Rini2020-03-31 10:06:52 -0400
commitdd4cf53f9864362d9e92472298ad60dcbb8b7e72 (patch)
treee3db02712e3e2f24409d69e9ca13f25b4304a55b /doc/device-tree-bindings/gpio
parent1d7ad9fa051e5b3057bccb6384ab62e4f9c206b2 (diff)
gpio: mpc8xxx: don't do RMW on gpdat register when setting value
The driver correctly handles reading back the value of an output gpio by reading from the shadow register for output, and from gpdat for inputs. Unfortunately, when setting the value of some gpio, we do a RMW cycle on the gpdat register without taking the shadow register into account, thus accidentally setting other output gpios (at least those whose value cannot be read back) to 0 at the same time. When changing a gpio from input to output, we still need to make sure it initially has the requested value. So, the procedure is - update the shadow register - compute the new gpdir register - write the bitwise and of the shadow and new gpdir register to gpdat - write the new gpdir register Signed-off-by: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
Diffstat (limited to 'doc/device-tree-bindings/gpio')
0 files changed, 0 insertions, 0 deletions