diff options
author | Bin Meng | 2019-09-09 06:00:01 -0700 |
---|---|---|
committer | Jagan Teki | 2019-10-25 00:48:31 +0530 |
commit | 4b060003957db07fa0e35beafe6559f9cc91954c (patch) | |
tree | ba4a762a7dbe6ed0c16a2a93e6b8a46c2f74876e /doc | |
parent | 4dd520b36bce9b35f7a12f3ffd9a95269d425170 (diff) |
dm: spi: Change cs_info op to return -EINVAL for invalid cs num
We need distinguish the following two situations in various SPI APIs:
- given chip select num is invalid
- given chip select num is valid, but no device is attached
Currently -ENODEV is returned for both cases.
For the first case, it's more reasonable to return -EINVAL instead of
-ENODEV for invalid chip select numbers.
Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
Tested-by: Jagan Teki <jagan@amarulasolutions.com> # SoPine
Reviewed-by: Jagan Teki <jagan@amarulasolutions.com>
Diffstat (limited to 'doc')
-rw-r--r-- | doc/driver-model/spi-howto.rst | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/doc/driver-model/spi-howto.rst b/doc/driver-model/spi-howto.rst index 44eab3947e7..9631a5059d3 100644 --- a/doc/driver-model/spi-howto.rst +++ b/doc/driver-model/spi-howto.rst @@ -116,7 +116,7 @@ Put this code at the bottom of your existing driver file: static int exynos_cs_info(struct udevice *bus, uint cs, struct spi_cs_info *info) { - return -ENODEV; + return -EINVAL; } static const struct dm_spi_ops exynos_spi_ops = { @@ -633,7 +633,7 @@ is not obvious from outside the driver. In this case you can provide a method for cs_info() to deal with this. If you don't provide it, then the device tree will be used to determine what chip selects are valid. -Return -ENODEV if the supplied chip select is invalid, or 0 if it is valid. +Return -EINVAL if the supplied chip select is invalid, or 0 if it is valid. If you don't provide the cs_info() method, 0 is assumed for all chip selects that do not appear in the device tree. |