diff options
| author | Heinrich Schuchardt | 2021-02-20 10:41:22 +0100 |
|---|---|---|
| committer | Simon Glass | 2021-03-22 19:23:26 +1300 |
| commit | c803838fa85d681a0ea60409fc81f596a2e9c07c (patch) | |
| tree | d937da5b14f0f4305eae7b4b485c443e0929054c /drivers/core/of_addr.c | |
| parent | 4a2a78ca5c2d70ff1e94a74ff2a96a440379dc01 (diff) | |
dm: error handling dev_get_dma_range()
goto after return has not effect. Calling of_node_put() in case of some
errors and not for others is inconsistent.
Fixes: 51bdb50904b ("dm: Introduce xxx_get_dma_range()")
Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
Reviewed-by: Simon Glass <sjg@chromium.org>
Diffstat (limited to 'drivers/core/of_addr.c')
| -rw-r--r-- | drivers/core/of_addr.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/core/of_addr.c b/drivers/core/of_addr.c index 5bc6ca1de01..b3e384d2ee1 100644 --- a/drivers/core/of_addr.c +++ b/drivers/core/of_addr.c @@ -372,7 +372,7 @@ int of_get_dma_range(const struct device_node *dev, phys_addr_t *cpu, bus_node->count_cells(dev, &na, &ns); if (!OF_CHECK_COUNTS(na, ns)) { printf("Bad cell count for %s\n", of_node_full_name(dev)); - return -EINVAL; + ret = -EINVAL; goto out_parent; } @@ -380,7 +380,7 @@ int of_get_dma_range(const struct device_node *dev, phys_addr_t *cpu, bus_node->count_cells(parent, &pna, &pns); if (!OF_CHECK_COUNTS(pna, pns)) { printf("Bad cell count for %s\n", of_node_full_name(parent)); - return -EINVAL; + ret = -EINVAL; goto out_parent; } |