diff options
author | Andre Przywara | 2020-07-06 01:40:43 +0100 |
---|---|---|
committer | Jagan Teki | 2020-10-21 23:45:06 +0530 |
commit | 7edcb4e288efb9eb4412373638dab87cd78d92ba (patch) | |
tree | d7de1c5f288aa2a5236c8e2481da286a167ac7fc /drivers/misc/cros_ec_spi.c | |
parent | 2c5600c38ce642e1763afe4f3b5fb6dd8f442aa5 (diff) |
net: sun8i_emac: Simplify and fix error handling for RX
The error handling in recv() is somewhat broken, for instance
good_packet isn't really used, and it's hardly readable. Also we try
to check for short or too big packets, but those are actually filtered
out by the hardware.
Simplify the whole routine and improve the error handling:
- Bail out early if the current RX descriptor is not ready.
- Enable propagation of runt, huge and broken packets.
- Check for runt and huge packets, and return 0 to indicate this.
This will force the framework to call free_pkt for cleanup.
- Avoid aligning the packet buffer for invalidation again.
Signed-off-by: Andre Przywara <andre.przywara@arm.com>
Acked-by: Maxime Ripard <mripard@kernel.org>
Tested-by: Amit Singh Tomar <amittomer25@gmail.com> # Pine64+
Reviewed-by: Jagan Teki <jagan@amarulasolutions.com>
Diffstat (limited to 'drivers/misc/cros_ec_spi.c')
0 files changed, 0 insertions, 0 deletions