aboutsummaryrefslogtreecommitdiff
path: root/drivers/pch
diff options
context:
space:
mode:
authorBin Meng2016-02-01 01:40:41 -0800
committerBin Meng2016-02-05 12:47:21 +0800
commitd02be99e6774b99c27b7d4304865c7f45e1ac4b4 (patch)
tree158ab527315a42bde5f46c10ff6c56f277e150bc /drivers/pch
parent254e6779258f9f3aa8ba67fb4506fd570fae9687 (diff)
dm: pch: Remove pch_get_version op
pch_get_version op was only used by the ich spi controller driver, and does not really provide a good identification of pch controller so far, since we see plenty of Intel PCH chipsets and one differs from another a lot, which is not simply either a PCHV_7 or PCHV_9. Now that ich spi controller driver was updated to not get such info from pch, the pch_get_version op is useless now. Signed-off-by: Bin Meng <bmeng.cn@gmail.com> Reviewed-by: Simon Glass <sjg@chromium.org> Tested-by: Simon Glass <sjg@chromium.org>
Diffstat (limited to 'drivers/pch')
-rw-r--r--drivers/pch/pch-uclass.c10
-rw-r--r--drivers/pch/pch7.c6
-rw-r--r--drivers/pch/pch9.c6
3 files changed, 0 insertions, 22 deletions
diff --git a/drivers/pch/pch-uclass.c b/drivers/pch/pch-uclass.c
index 4579ed12f65..cae4f50e57a 100644
--- a/drivers/pch/pch-uclass.c
+++ b/drivers/pch/pch-uclass.c
@@ -23,16 +23,6 @@ int pch_get_sbase(struct udevice *dev, ulong *sbasep)
return ops->get_sbase(dev, sbasep);
}
-enum pch_version pch_get_version(struct udevice *dev)
-{
- struct pch_ops *ops = pch_get_ops(dev);
-
- if (!ops->get_version)
- return -ENOSYS;
-
- return ops->get_version(dev);
-}
-
int pch_set_spi_protect(struct udevice *dev, bool protect)
{
struct pch_ops *ops = pch_get_ops(dev);
diff --git a/drivers/pch/pch7.c b/drivers/pch/pch7.c
index ef724221c2e..7c6a2ca086f 100644
--- a/drivers/pch/pch7.c
+++ b/drivers/pch/pch7.c
@@ -22,11 +22,6 @@ static int pch7_get_sbase(struct udevice *dev, ulong *sbasep)
return 0;
}
-static enum pch_version pch7_get_version(struct udevice *dev)
-{
- return PCHV_7;
-}
-
static int pch7_set_spi_protect(struct udevice *dev, bool protect)
{
uint8_t bios_cntl;
@@ -44,7 +39,6 @@ static int pch7_set_spi_protect(struct udevice *dev, bool protect)
static const struct pch_ops pch7_ops = {
.get_sbase = pch7_get_sbase,
- .get_version = pch7_get_version,
.set_spi_protect = pch7_set_spi_protect,
};
diff --git a/drivers/pch/pch9.c b/drivers/pch/pch9.c
index 529cb023e2b..27a9fda0f4e 100644
--- a/drivers/pch/pch9.c
+++ b/drivers/pch/pch9.c
@@ -20,14 +20,8 @@ static int pch9_get_sbase(struct udevice *dev, ulong *sbasep)
return 0;
}
-static enum pch_version pch9_get_version(struct udevice *dev)
-{
- return PCHV_9;
-}
-
static const struct pch_ops pch9_ops = {
.get_sbase = pch9_get_sbase,
- .get_version = pch9_get_version,
};
static const struct udevice_id pch9_ids[] = {