diff options
| author | Marek Vasut | 2012-10-06 14:07:03 +0000 |
|---|---|---|
| committer | Tom Rini | 2012-10-17 07:55:50 -0700 |
| commit | 6d93e25806337d46ee75c6703b3ecc972cb179a5 (patch) | |
| tree | fa85fb257af47aba038533d52d94eca76afa8216 /drivers/serial/serial.c | |
| parent | ec3fd68952662b1badb02caab9705eb93bdc4f1b (diff) | |
serial: Reorder serial_assign()
Reorder serial_assign() function to get rid of the extra level of
indentation. Also, adjust the return value to be -EINVAL instead of
positive one to be more consistent.
Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Marek Vasut <marek.vasut@gmail.com>
Cc: Tom Rini <trini@ti.com>
Diffstat (limited to 'drivers/serial/serial.c')
| -rw-r--r-- | drivers/serial/serial.c | 11 |
1 files changed, 6 insertions, 5 deletions
diff --git a/drivers/serial/serial.c b/drivers/serial/serial.c index d648a73f411..3ab323bcb88 100644 --- a/drivers/serial/serial.c +++ b/drivers/serial/serial.c @@ -26,6 +26,7 @@ #include <stdio_dev.h> #include <post.h> #include <linux/compiler.h> +#include <errno.h> DECLARE_GLOBAL_DATA_PTR; @@ -205,13 +206,13 @@ int serial_assign(const char *name) struct serial_device *s; for (s = serial_devices; s; s = s->next) { - if (strcmp(s->name, name) == 0) { - serial_current = s; - return 0; - } + if (strcmp(s->name, name)) + continue; + serial_current = s; + return 0; } - return 1; + return -EINVAL; } void serial_reinit_all(void) |