diff options
| author | Igor Prusov | 2023-12-06 02:23:33 +0300 |
|---|---|---|
| committer | Sean Anderson | 2023-12-15 12:32:00 -0500 |
| commit | 54d7da77306257a03231b04e7f2f9393ad7b0e46 (patch) | |
| tree | 1b4d6e2aca365574898eebae9e56892eebb6a184 /drivers | |
| parent | 3fb2d3d6acbaad50d2e638f6abb4e9d7a511c462 (diff) | |
clk: Check that composite clock's div has set_rate()
It's possible for composite clocks to have a divider that does not
implement set_rate() operation. For example, sandbox_clk_composite()
registers composite clock with a divider that only has get_rate().
Currently clk_composite_set_rate() only checks thate rate_ops are
present, so for sandbox it will cause NULL dereference during
clk_set_rate().
This patch adds rate_ops->set_rate check tp clk_composite_set_rate().
Signed-off-by: Igor Prusov <ivprusov@salutedevices.com>
Reviewed-by: Sean Anderson <seanga2@gmail.com>
Link: https://lore.kernel.org/r/20231205232334.2931-2-ivprusov@salutedevices.com
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/clk/clk-composite.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/clk/clk-composite.c b/drivers/clk/clk-composite.c index 6eb2b8133a3..d2e5a1ae401 100644 --- a/drivers/clk/clk-composite.c +++ b/drivers/clk/clk-composite.c @@ -66,7 +66,7 @@ static ulong clk_composite_set_rate(struct clk *clk, unsigned long rate) const struct clk_ops *rate_ops = composite->rate_ops; struct clk *clk_rate = composite->rate; - if (rate && rate_ops) + if (rate && rate_ops && rate_ops->set_rate) return rate_ops->set_rate(clk_rate, rate); else return clk_get_rate(clk); |