diff options
| author | Sean Anderson | 2023-09-30 16:45:46 -0400 |
|---|---|---|
| committer | Tom Rini | 2023-10-11 13:22:32 -0400 |
| commit | 89cfa35bfc4c5bcabdcf31c8e4631e0dddd508c3 (patch) | |
| tree | 9fdf823aca2ee8961afdc806b95a0dee9aa2d257 /drivers | |
| parent | 4cb6c8e5f0de3c4c5f9eba51c6a1610934a8cf77 (diff) | |
misc: fs_loader: Fix alignment of fs_loader driver
DM_DRIVER_GET will redeclare the fs_loader driver without the correct
alignment. This causes GCC to use the default section alignment of 32
bytes. This in turn creates a gap in the linker list due to the padding
required to achieve the correct alignment, corrupting all further entries.
Use DM_DRIVER_REF instead, which doesn't redeclare anything.
Fixes: 0998a20cfc6 ("misc: fs_loader: Add function to get the chosen loader")
Signed-off-by: Sean Anderson <seanga2@gmail.com>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/misc/fs_loader.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/misc/fs_loader.c b/drivers/misc/fs_loader.c index ccf5c7a8037..1ffc199ba1e 100644 --- a/drivers/misc/fs_loader.c +++ b/drivers/misc/fs_loader.c @@ -316,7 +316,7 @@ int get_fs_loader(struct udevice **dev) return ret; /* Just create a new device */ - ret = device_bind(dm_root(), DM_DRIVER_GET(fs_loader), "default-loader", + ret = device_bind(dm_root(), DM_DRIVER_REF(fs_loader), "default-loader", &default_plat, ofnode_null(), dev); if (ret) return ret; |