diff options
| author | Marek Behún | 2021-10-17 17:36:30 +0200 |
|---|---|---|
| committer | Simon Glass | 2021-10-21 12:50:48 -0600 |
| commit | 52f9ed34cb3768663ee9c2e5d980143e8ac783a9 (patch) | |
| tree | 3ed3975ae5952d9b2f503884e05ef63ffb29058c /env/nowhere.c | |
| parent | 7b611ee90e1e4db531c4e3896efebfdc0743725d (diff) | |
env: Inline env_get_char() into its only user
This function is a relic from the past when environment was read from
underlying device one character at a time.
It is used only in the case when getting an environemnt variable prior
relocation, and the function is simple enough to be inlined there.
Since env_get_char() is being changed to simple access to an array, we
can drop the failing cases and simplify the code (this could have been
done before, since env_get_char() did not fail even before).
Signed-off-by: Marek Behún <marek.behun@nic.cz>
Reviewed-by: Simon Glass <sjg@chromium.org>
Diffstat (limited to 'env/nowhere.c')
| -rw-r--r-- | env/nowhere.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/env/nowhere.c b/env/nowhere.c index 41557f5ce44..1fcf5034535 100644 --- a/env/nowhere.c +++ b/env/nowhere.c @@ -31,9 +31,8 @@ static int env_nowhere_init(void) static int env_nowhere_load(void) { /* - * for SPL, set env_valid = ENV_INVALID is enough as env_get_char() - * return the default env if env_get is used - * and SPL don't used env_import to reduce its size + * For SPL, setting env_valid = ENV_INVALID is enough, as env_get() + * searches default_environment array in that case. * For U-Boot proper, import the default environment to allow reload. */ if (!IS_ENABLED(CONFIG_SPL_BUILD)) |