diff options
| author | Eugeniu Rosca | 2020-10-23 11:52:23 +0300 |
|---|---|---|
| committer | Marek Vasut | 2021-01-31 14:08:56 +0100 |
| commit | bafdf4caac15bd14c4926c8935e1a22e297fb0e3 (patch) | |
| tree | 0f024dbb2ffc82fe27eed675c3cb414162ce66e2 /include/bcb.h | |
| parent | e74670adfe6425b94b8615b74b8aadc5425fb246 (diff) | |
cmd: bcb: Add support for processing const string literals in bcb_set()
On request/suggestion from Simon Glass back in May 22 2019 [1], the
'strsep' mechanism implemented in bcb_set() was set to work directly
with user-provided argv strings, to avoid duplicating memory and for
the sake of simpler implementation.
However, since we recently exposed bcb_write_reboot_reason() API to be
called by U-Boot fastboot, the idea is to be able to pass const string
literals to this new BCB API, carrying the reboot reason.
Since 'strsep' (just like its older/superseded sibling 'strtok')
modifies the input string passed as parameter, BCB command in its
current state would attempt to perform in-place modifications in a
readonly string, which might lead to unexpected results.
Fix the above with the cost of one dynamic memory allocation ('strdup').
This will also ensure no compiler warnings when passing string literals
to bcb_write_reboot_reason().
[1] http://u-boot.10912.n7.nabble.com/PATCH-v2-0-2-Add-bcb-command-to-read-modify-write-Android-BCB-td369934i20.html#a370456
Cc: Simon Glass <sjg@chromium.org>
Signed-off-by: Eugeniu Rosca <erosca@de.adit-jv.com>
Signed-off-by: Roman Kovalivskyi <roman.kovalivskyi@globallogic.com>
Diffstat (limited to 'include/bcb.h')
| -rw-r--r-- | include/bcb.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/include/bcb.h b/include/bcb.h index 5bb8d8346c1..897e83d371f 100644 --- a/include/bcb.h +++ b/include/bcb.h @@ -9,10 +9,10 @@ #define __BCB_H__ #if CONFIG_IS_ENABLED(CMD_BCB) -int bcb_write_reboot_reason(int devnum, char *partp, char *reasonp); +int bcb_write_reboot_reason(int devnum, char *partp, const char *reasonp); #else #include <linux/errno.h> -static inline int bcb_write_reboot_reason(int devnum, char *partp, char *reasonp) +static inline int bcb_write_reboot_reason(int devnum, char *partp, const char *reasonp) { return -EOPNOTSUPP; } |