diff options
| author | Simon Glass | 2023-03-28 08:34:14 +1300 |
|---|---|---|
| committer | Tom Rini | 2023-03-28 09:25:51 -0400 |
| commit | be0169f07e38b81dd96bca2e80610592d89f8550 (patch) | |
| tree | 09e08eefd123e358b5012df3dd88f233547b64d8 /include/cli.h | |
| parent | 17b45e684af98c1cf37648ad05a98d500b367c5a (diff) | |
cli: Correct handling of invalid escape sequences in cread_line()
The second call to cli_ch_process() is in the wrong place, meaning that
the one of the characters of an invalid escape sequence is swallowed
instead of being returned.
Fix the bug and add a test to cover this.
This behaviour matches that of the code before cli_getch() was
introduced. This was verified on the commit before b08e9d4b66 i.e.:
7d850f85aad ("sandbox: Enable mmc command and legacy images")
Signed-off-by: Simon Glass <sjg@chromium.org>
Reported-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
Diffstat (limited to 'include/cli.h')
| -rw-r--r-- | include/cli.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/include/cli.h b/include/cli.h index c777c90313f..094a6602d70 100644 --- a/include/cli.h +++ b/include/cli.h @@ -98,8 +98,8 @@ int cli_readline(const char *const prompt); * * @prompt: Prompt to display * @buffer: Place to put the line that is entered - * @timeout: Timeout in milliseconds, 0 if none - * Return: command line length excluding terminator, or -ve on error: of the + * @timeout: Timeout in seconds, 0 if none + * Return: command line length excluding terminator, or -ve on error: if the * timeout is exceeded (either CONFIG_BOOT_RETRY_TIME or the timeout * parameter), then -2 is returned. If a break is detected (Ctrl-C) then * -1 is returned. |