diff options
| author | Simon Glass | 2022-09-06 20:27:05 -0600 |
|---|---|---|
| committer | Tom Rini | 2022-09-29 16:09:56 -0400 |
| commit | 0e4b697f884d1f2190a9972b662abc8498159333 (patch) | |
| tree | 0d81dadb200fadc7a74a0d1cece914af244f4fa7 /include/test | |
| parent | 98306987659769607642474954b2bf9555808542 (diff) | |
test: Make a copy of the device tree before running a test
When the flat device tree changes it can mess up the live tree since that
uses the flat tree for its strings. This affects only a few sandbox tests
which modify the device tree, but the number will grow as ofnode support
for writing improves.
While the control FDT is not intended to change while U-Boot is running,
some tests do so. For example, the ofnode interface only supports
modifying properties in the control FDT, so tests must use that.
To solve this problem, keep a copy of the FDT and restore it as needed
when the test is finished. The copy only happens on sandbox (except SPL
builds), to reduce memory usage and because these tests are not useful on
other boards. For other boards, a checksum is taken to ensure that nothing
changes.
It would be possible to always checksum the FDT on sandbox and only
restore it if needed, but this is slightly slower than restoring it every
time, at least with crc8.
Move the code which checks for success to the very end, for clarity.
Signed-off-by: Simon Glass <sjg@chromium.org>
Diffstat (limited to 'include/test')
| -rw-r--r-- | include/test/test.h | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/include/test/test.h b/include/test/test.h index 799e9180863..92215d427b0 100644 --- a/include/test/test.h +++ b/include/test/test.h @@ -20,6 +20,9 @@ * @testdev: Test device * @force_fail_alloc: Force all memory allocs to fail * @skip_post_probe: Skip uclass post-probe processing + * @fdt_chksum: crc8 of the device tree contents + * @fdt_copy: Copy of the device tree + * @fdt_size: Size of the device-tree copy * @runs_per_test: Number of times to run each test (typically 1) * @expect_str: Temporary string used to hold expected string value * @actual_str: Temporary string used to hold actual string value @@ -33,6 +36,9 @@ struct unit_test_state { struct udevice *testdev; int force_fail_alloc; int skip_post_probe; + uint fdt_chksum; + void *fdt_copy; + uint fdt_size; int runs_per_test; char expect_str[512]; char actual_str[512]; |