diff options
| author | Wojciech Nizinski | 2023-09-25 12:37:15 +0200 |
|---|---|---|
| committer | Mattijs Korpershoek | 2023-10-31 14:36:30 +0100 |
| commit | 355aab94d1f675ec1118906e1f88dfdf6a3582eb (patch) | |
| tree | d278e353aeb97ff64125738cc2ec1ff0e6bbed35 /lib | |
| parent | cbba1b7766bd93d74e28202c46e69095ac13760b (diff) | |
fastboot: fix CRC32 chunk size checking
genimage create android-sparse file with CRC32 chunk at end. When
U-Boot's fastboot receives this chunk it returns error message:
`Fail Bogus chunk size for chunk type Dont Care`
According to reference implementation of Android's sparse file format:
<https://android.googlesource.com/platform/system/core/+/refs/heads/main/
libsparse/output_file.cpp#513>
the chunk_header.total_sz is CHUNK_HEADER_LEN + 4 (CRC32 size).
Signed-off-by: Wojciech Nizinski <niziak@spox.org>
Reviewed-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>
Tested-by: Mattijs Korpershoek <mkorpershoek@baylibre.com> # on vim3
Link: https://lore.kernel.org/r/20230925103714.4153612-1-niziak@spox.org
Signed-off-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>
Diffstat (limited to 'lib')
| -rw-r--r-- | lib/image-sparse.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/lib/image-sparse.c b/lib/image-sparse.c index 8f8a67e1580..323aad981c6 100644 --- a/lib/image-sparse.c +++ b/lib/image-sparse.c @@ -289,8 +289,8 @@ int write_sparse_image(struct sparse_storage *info, case CHUNK_TYPE_CRC32: if (chunk_header->total_sz != - sparse_header->chunk_hdr_sz) { - info->mssg("Bogus chunk size for chunk type Dont Care", + sparse_header->chunk_hdr_sz + sizeof(uint32_t)) { + info->mssg("Bogus chunk size for chunk type CRC32", response); return -1; } |