diff options
| author | Heinrich Schuchardt | 2023-07-30 12:59:32 +0200 |
|---|---|---|
| committer | Heinrich Schuchardt | 2023-08-03 09:21:02 +0200 |
| commit | ecae4bbf35fac3cde0c41c012a05c8e5b4ade90f (patch) | |
| tree | 5e9fca8181aee557687cf422c15e9e1cb30098f9 /lib | |
| parent | 257a498fbb146f866d729176a6fce5875323d4b9 (diff) | |
efi_loader: memory leak efi_add_memory_map_pg
Don't leak newlist if we error out.
Fixes: 74c16acce30b ("efi_loader: Don't allocate from memory holes")
Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
Reviewed-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
Diffstat (limited to 'lib')
| -rw-r--r-- | lib/efi_loader/efi_memory.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/lib/efi_loader/efi_memory.c b/lib/efi_loader/efi_memory.c index 45d3bf52b8a..ebf4a2d5fa3 100644 --- a/lib/efi_loader/efi_memory.c +++ b/lib/efi_loader/efi_memory.c @@ -324,6 +324,7 @@ static efi_status_t efi_add_memory_map_pg(u64 start, u64 pages, * The user requested to only have RAM overlaps, * but we hit a non-RAM region. Error out. */ + free(newlist); return EFI_NO_MAPPING; case EFI_CARVE_NO_OVERLAP: /* Just ignore this list entry */ @@ -354,6 +355,7 @@ static efi_status_t efi_add_memory_map_pg(u64 start, u64 pages, * The payload wanted to have RAM overlaps, but we overlapped * with an unallocated region. Error out. */ + free(newlist); return EFI_NO_MAPPING; } |