diff options
| author | Simon Glass | 2023-07-19 17:48:19 -0600 |
|---|---|---|
| committer | Simon Glass | 2023-07-24 09:34:10 -0600 |
| commit | bc12d03493d7aa1bdda6d9dc40e2457fb8e33684 (patch) | |
| tree | 9db3faf8c36534c301a0e7c954902e055815cee6 /tools/buildman/func_test.py | |
| parent | a114c6153699d0a9f3730d630a04a3c6c648a775 (diff) | |
buildman: Warn about dangling maintainer entries
Other than the top-level MAINTAINERS file, all maintainer entries should
actually reference a target. Add a warning to detect those that do not.
Signed-off-by: Simon Glass <sjg@chromium.org>
Diffstat (limited to 'tools/buildman/func_test.py')
| -rw-r--r-- | tools/buildman/func_test.py | 9 |
1 files changed, 6 insertions, 3 deletions
diff --git a/tools/buildman/func_test.py b/tools/buildman/func_test.py index 43087b4e08d..eb1fa9f0b86 100644 --- a/tools/buildman/func_test.py +++ b/tools/buildman/func_test.py @@ -917,7 +917,8 @@ Active aarch64 armv8 - armltd total_compute board2 params_list, warnings = self._boards.build_board_list(config_dir, src) self.assertEquals(2, len(params_list)) self.assertEquals( - ["WARNING: no status info for 'board0'", + ['WARNING: orphaned defconfig in boards/board0/MAINTAINERS ending at line 4', + "WARNING: no status info for 'board0'", "WARNING: no maintainers for 'board0'"], warnings) # Remove the maintainer line (M:) from a file (this should be fine) @@ -937,9 +938,11 @@ Active aarch64 armv8 - armltd total_compute board2 self.assertEquals(2, len(params_list)) self.assertFalse(warnings) - # Add another record, this should be ignored + # Add another record, this should be ignored with a warning extra = '\n\nAnother\nM: Fred\nF: configs/board9_defconfig\nS: other\n' tools.write_file(main, data + extra, binary=False) params_list, warnings = self._boards.build_board_list(config_dir, src) self.assertEquals(2, len(params_list)) - self.assertFalse(warnings) + self.assertEquals( + ['WARNING: orphaned defconfig in boards/board0/MAINTAINERS ending at line 16'], + warnings) |