aboutsummaryrefslogtreecommitdiff
path: root/tools/dtoc
diff options
context:
space:
mode:
authorSimon Glass2019-07-20 12:23:23 -0600
committerSimon Glass2019-07-29 09:38:05 -0600
commit1000096b06ea53487b3457eb1d0d1704276c1c62 (patch)
treec6e92c7f6197867f8dd40ca8c9769a4869931bf1 /tools/dtoc
parent75551c8bfc9545e31ec2ce238cac3857904007b8 (diff)
dtoc: Return a non-zero exit code when tests fail
At present 'dtoc -t' return a success code even if some of the tests fail. Fix this by checking the test result and setting the exit code. This allows 'make qcheck' to function as expected. Signed-off-by: Simon Glass <sjg@chromium.org>
Diffstat (limited to 'tools/dtoc')
-rwxr-xr-xtools/dtoc/dtoc.py7
1 files changed, 6 insertions, 1 deletions
diff --git a/tools/dtoc/dtoc.py b/tools/dtoc/dtoc.py
index c1a1d3534d4..514e0dd4a34 100755
--- a/tools/dtoc/dtoc.py
+++ b/tools/dtoc/dtoc.py
@@ -71,6 +71,10 @@ def run_tests(args):
print(err)
for _, err in result.failures:
print(err)
+ if result.errors or result.failures:
+ print('dtoc tests FAILED')
+ return 1
+ return 0
def RunTestCoverage():
"""Run the tests and check that we get 100% coverage"""
@@ -101,7 +105,8 @@ parser.add_option('-T', '--test-coverage', action='store_true',
# Run our meagre tests
if options.test:
- run_tests(args)
+ ret_code = run_tests(args)
+ sys.exit(ret_code)
elif options.test_coverage:
RunTestCoverage()