aboutsummaryrefslogtreecommitdiff
path: root/tools/patman/status.py
diff options
context:
space:
mode:
authorSimon Glass2020-11-03 13:54:14 -0700
committerSimon Glass2020-11-14 15:23:41 -0700
commit7cbf02e94df820b77b53ae113828b294688bf623 (patch)
tree94427da3bd2e4b37c4180bfb4abcfa9140f62a69 /tools/patman/status.py
parent3145b63513552fc77f6584a89baf0966617eeadf (diff)
patman: Allow specifying the patchwork URL
Add a new argument to allow the URL of the patchwork server to be speciified. For now this is hard-coded in the main file, but future patches will move it to the settings file. Signed-off-by: Simon Glass <sjg@chromium.org>
Diffstat (limited to 'tools/patman/status.py')
-rw-r--r--tools/patman/status.py29
1 files changed, 17 insertions, 12 deletions
diff --git a/tools/patman/status.py b/tools/patman/status.py
index a369d655c5e..f3fbc661b2f 100644
--- a/tools/patman/status.py
+++ b/tools/patman/status.py
@@ -198,10 +198,11 @@ def compare_with_series(series, patches):
return patch_for_commit, commit_for_patch, warnings
-def call_rest_api(subpath):
+def call_rest_api(url, subpath):
"""Call the patchwork API and return the result as JSON
Args:
+ url (str): URL of patchwork server, e.g. 'https://patchwork.ozlabs.org'
subpath (str): URL subpath to use
Returns:
@@ -210,13 +211,13 @@ def call_rest_api(subpath):
Raises:
ValueError: the URL could not be read
"""
- url = 'https://patchwork.ozlabs.org/api/1.2/%s' % subpath
- response = requests.get(url)
+ full_url = '%s/api/1.2/%s' % (url, subpath)
+ response = requests.get(full_url)
if response.status_code != 200:
- raise ValueError("Could not read URL '%s'" % url)
+ raise ValueError("Could not read URL '%s'" % full_url)
return response.json()
-def collect_patches(series, series_id, rest_api=call_rest_api):
+def collect_patches(series, series_id, url, rest_api=call_rest_api):
"""Collect patch information about a series from patchwork
Uses the Patchwork REST API to collect information provided by patchwork
@@ -226,6 +227,7 @@ def collect_patches(series, series_id, rest_api=call_rest_api):
series (Series): Series object corresponding to the local branch
containing the series
series_id (str): Patch series ID number
+ url (str): URL of patchwork server, e.g. 'https://patchwork.ozlabs.org'
rest_api (function): API function to call to access Patchwork, for
testing
@@ -236,7 +238,7 @@ def collect_patches(series, series_id, rest_api=call_rest_api):
ValueError: if the URL could not be read or the web page does not follow
the expected structure
"""
- data = rest_api('series/%s/' % series_id)
+ data = rest_api(url, 'series/%s/' % series_id)
# Get all the rows, which are patches
patch_dict = data['patches']
@@ -261,7 +263,7 @@ def collect_patches(series, series_id, rest_api=call_rest_api):
patches = sorted(patches, key=lambda x: x.seq)
return patches
-def find_new_responses(new_rtag_list, review_list, seq, cmt, patch,
+def find_new_responses(new_rtag_list, review_list, seq, cmt, patch, url,
rest_api=call_rest_api):
"""Find new rtags collected by patchwork that we don't know about
@@ -279,6 +281,7 @@ def find_new_responses(new_rtag_list, review_list, seq, cmt, patch,
seq (int): Position in new_rtag_list to update
cmt (Commit): Commit object for this commit
patch (Patch): Corresponding Patch object for this patch
+ url (str): URL of patchwork server, e.g. 'https://patchwork.ozlabs.org'
rest_api (function): API function to call to access Patchwork, for
testing
"""
@@ -286,14 +289,14 @@ def find_new_responses(new_rtag_list, review_list, seq, cmt, patch,
return
# Get the content for the patch email itself as well as all comments
- data = rest_api('patches/%s/' % patch.id)
+ data = rest_api(url, 'patches/%s/' % patch.id)
pstrm = PatchStream.process_text(data['content'], True)
rtags = collections.defaultdict(set)
for response, people in pstrm.commit.rtags.items():
rtags[response].update(people)
- data = rest_api('patches/%s/comments/' % patch.id)
+ data = rest_api(url, 'patches/%s/comments/' % patch.id)
reviews = []
for comment in data:
@@ -407,7 +410,7 @@ def create_branch(series, new_rtag_list, branch, dest_branch, overwrite,
return num_added
def check_patchwork_status(series, series_id, branch, dest_branch, force,
- show_comments, rest_api=call_rest_api,
+ show_comments, url, rest_api=call_rest_api,
test_repo=None):
"""Check the status of a series on Patchwork
@@ -421,11 +424,12 @@ def check_patchwork_status(series, series_id, branch, dest_branch, force,
dest_branch (str): Name of new branch to create, or None
force (bool): True to force overwriting dest_branch if it exists
show_comments (bool): True to show the comments on each patch
+ url (str): URL of patchwork server, e.g. 'https://patchwork.ozlabs.org'
rest_api (function): API function to call to access Patchwork, for
testing
test_repo (pygit2.Repository): Repo to use (use None unless testing)
"""
- patches = collect_patches(series, series_id, rest_api)
+ patches = collect_patches(series, series_id, url, rest_api)
col = terminal.Color()
count = len(series.commits)
new_rtag_list = [None] * count
@@ -440,7 +444,8 @@ def check_patchwork_status(series, series_id, branch, dest_branch, force,
with concurrent.futures.ThreadPoolExecutor(max_workers=16) as executor:
futures = executor.map(
find_new_responses, repeat(new_rtag_list), repeat(review_list),
- range(count), series.commits, patch_list, repeat(rest_api))
+ range(count), series.commits, patch_list, repeat(url),
+ repeat(rest_api))
for fresponse in futures:
if fresponse:
raise fresponse.exception()